316 implement urbanrural classification for ni

[paigeh-fsa]

Pull Request submission

I have included the urban and rural data for Northern Ireland, and uploaded this to sync. A new folder will have to be created and stored here: data/urban_rural/NI/NI_urb_rur_class.csv

I have gone with the definition that we are making urban >10,000 and rural as <10,000. This means that bands A-D are urban and E-H are rural.

I have also included a new function that does the urban rural classification across all 3 scripts

Closes or fixes

Fixes #316

Code

• [x] Requirements My/our code matches the requirements of the ticket
• [x] Functionality: New functions meet requirements in issue ticket
• [x] Compliant Code Code is as PEP 8 compliant as I can humanly make it
• [x] Code runs The code runs on my machine
• [x] Clean Code
  • [ ] Code has been linted (use your favourite linter)
  • [x] Code adheres to DRY

Documentation

Any new code includes all the following forms of documentation:

• [x] Function Documentation Docstrings within the function(s') definition(s) have been created
  • [x] Includes parameters and returns for all major functions
  • [ ] Includes data types
• [x] Updated Documentation: Working doc has been updated and a new ticket to update the master documentation has been created.

Data

• [x] All data needed to run this script has been added to Sync

---

Peer Review Section

• [ ] All requirements install from (updated) requirements.txt
• [ ] Documentation has been created and is clear - check the google Doc
• [ ] Doctrings (Google format) have been created and accurately describe the function's functionality
• [ ] Unit tests pass, or if not present a new ticket to create tests has been created
• [ ] Code runs The code runs on reviewer's machine

Final approval (post-review)

The author has responded to my review and made changes to my satisfaction.

• [ ] I recommend merging this request.

---

Review comments

Insert detailed comments here!

These might include, but not exclusively:

• bugs that need fixing (does it work as expected? and does it work with other code that it is likely to interact with?)
• alternative methods (could it be written more efficiently or with more clarity?)
• documentation improvements (does the documentation reflect how the code actually works?)
• additional tests that should be implemented (do the tests effectively assure that it works correctly?)
• code style improvements (could the code be written more clearly?)

Your suggestions should be tailored to the code that you are reviewing. Be critical and clear, but not mean. Ask questions and set actions.

[paigeh-fsa]

Hi @Antonio-John I have done this now and saved them with different names. When we combine data together in our final output these will have to be removed from the config.