374 scotland output bug

[nkshaw23]

Pull Request submission

A quick and dirty fix. When we undertake #381 I will properly check and remove all unneeded columns as per #380.

Duplicate easting and northing columns dropped when we undertake intersect between pwc and stops buffer. Reverted function back to original find_points_in_poly like eng, wales and NI use.

Removed points_in_polygon function as non longer used.

Tested on Fife and matches figures in QGIS (#352)

I have loads of linting errors but have left as wondering whether they are corrected in #369.

Closes #374

---

Peer Review Section

• [ ] All requirements install from (updated) requirements.txt
• [ ] Documentation has been created and is clear - check the google Doc
• [ ] Doctrings (Google format) have been created and accurately describe the function's functionality
• [ ] Unit tests pass, or if not present a new ticket to create tests has been created
• [ ] Code runs The code runs on reviewer's machine

Final approval (post-review)

The author has responded to my review and made changes to my satisfaction.

• [ ] I recommend merging this request.

---

Review comments

Insert detailed comments here!

These might include, but not exclusively:

• bugs that need fixing (does it work as expected? and does it work with other code that it is likely to interact with?)
• alternative methods (could it be written more efficiently or with more clarity?)
• documentation improvements (does the documentation reflect how the code actually works?)
• additional tests that should be implemented (do the tests effectively assure that it works correctly?)
• code style improvements (could the code be written more clearly?)

Your suggestions should be tailored to the code that you are reviewing. Be critical and clear, but not mean. Ask questions and set actions.

[james-westwood]

I certainly did a lot of linting in #331 for #369. But I am not sure I covered all files. Going back to check that now.