ONSdigital / SDG_11.2.1

Analysis for the UN Sustainable Development Goal 11.2.1
https://onsdigital.github.io/SDG_11.2.1/
Apache License 2.0
5 stars 7 forks source link

397 mkdocstrings #414

Closed james-westwood closed 1 year ago

james-westwood commented 1 year ago

Pull Request submission

The workflow (pages.yml) has been modified to include the installation of mkdocstrings and its associated dependencies (mkdocstrings-python and Pygments have been explicitly installed) alongside mkdocs. The deployment process remains the same, with the additional flags for control and verbosity during deployment.

Technical documentation has been produced. This is already deployed at https://onsdigital.github.io/SDG_11.2.1/

Even though it wasn't part of this ticket I've put the updated EU Method Comparison in here: docs/comparison_to_EU_method.md

And I have improved the mkdocs.yml so that it has the navigation of the technical documentation available.

Instructions

Go to https://onsdigital.github.io/SDG_11.2.1/ and review the pages. You can also install the dependencies locally and run mkdocs serve to see a local copy of the pages. (This is particularly good if you are updating the pages and don't want to have to push them to see them).

Closes or fixes

Closes #397

Code


Peer Review Section

Final approval (post-review)

The author has responded to my review and made changes to my satisfaction.


Review comments

Insert detailed comments here!

These might include, but not exclusively:

Your suggestions should be tailored to the code that you are reviewing. Be critical and clear, but not mean. Ask questions and set actions.

paigeh-fsa commented 1 year ago

Hi James, not sure if it's me but I'm not seeing the technical docstrings on the mkdocs? Haven't looked at the rest yet! Also to note that I cleared my cache in case

Screenshot 2023-05-19 at 16 11 42

Maybe I'm slightly confused, I thought it was adding in the technical documentation for the docstrings! :)