I have created a function which calculates mid-year age estimates in NI only. This is supposed to be for v1.1. however we have the work already committed here. I've commented out some extra bits I started on in the main script like reading in some NI mid-year estimates data as it's not necessary until we start v1.1. I've tried to make it clear in comments where 1.1 work is so we can make a start after we release 1.0. Hopefully it should run normally if you have all the correct data :)
Closes or fixes
Fixes #412 and #392
Code
[x] Requirements My/our code matches the requirements of the ticket
[x] Functionality: New functions meet requirements in issue ticket
[x] Compliant Code Code is as PEP 8 compliant as I can humanly make it
[x] Code runs The code runs on my machine
[x] Clean Code
[ ] Code has been linted (use your favourite linter)
Pull Request submission
I have created a function which calculates mid-year age estimates in NI only. This is supposed to be for v1.1. however we have the work already committed here. I've commented out some extra bits I started on in the main script like reading in some NI mid-year estimates data as it's not necessary until we start v1.1. I've tried to make it clear in comments where 1.1 work is so we can make a start after we release 1.0. Hopefully it should run normally if you have all the correct data :)
Closes or fixes
Fixes #412 and #392
Code
Documentation
Any new code includes all the following forms of documentation:
parameters
andreturns
for all major functionsData
Testing
Peer Review Section
requirements.txt
Final approval (post-review)
The author has responded to my review and made changes to my satisfaction.
Review comments
Insert detailed comments here!
These might include, but not exclusively:
Your suggestions should be tailored to the code that you are reviewing. Be critical and clear, but not mean. Ask questions and set actions.