ONSdigital / csvw-check

A CLI to validate CSV-Ws (W3C's CSV on the Web standard).
Apache License 2.0
1 stars 1 forks source link

#77 Massive refactor + supporting CSV-W HTTP Headers Properly #108

Closed robons closed 1 year ago

robons commented 1 year ago

The only thing I can think it would be worthwhile removing now is the unnecessary PropertyType enum and the necessity to pass it in to each of the normalisers - but it doesn't cause toooo much pain.

This PR doesn't leave the project in any kind of perfect position, but I'm confident that it meets 98+% of the W3C's CSV-W specification. I believe it leaves the code-base in a state which is much closer to maintainable than when I found it - but I do want to emphasise that it falls a lot short of what I would like to have done, had I more time.

github-actions[bot] commented 1 year ago

Unit and Cucumber Test Results

482 tests   482 :heavy_check_mark:  29s :stopwatch:   17 suites      0 :zzz:   17 files        0 :x:

Results for commit 8b480788.

:recycle: This comment has been updated with latest results.