ONSdigital / design-system

ONS Design System
https://service-manual.ons.gov.uk/design-system
MIT License
31 stars 20 forks source link

A spacing scale #1935

Open yatesn opened 2 years ago

yatesn commented 2 years ago

It would be a good idea to introduce a spacing scale or improve the one that is not being fully utilised.

This would ensure consistency in design and development. It would also be easier to understand than a variation of rem and px values. In some cases, I see a utility measure system in place and other times various 'px' and 'rem' values.

GDS uses a static measure and a responsive measure system which works very well. https://design-system.service.gov.uk/styles/spacing/

NHS: Spacing: https://github.com/nhsuk/nhsuk-frontend/blob/6a0997f758ff4d449f71ecc4ed66cef4287bbe99/packages/core/settings/_spacing.scss Typography scale: https://github.com/nhsuk/nhsuk-frontend/blob/6a0997f758ff4d449f71ecc4ed66cef4287bbe99/packages/core/settings/_typography.scss

yatesn commented 2 years ago

Will require a lot of testing

Sprint 14 or 15?

jrbarnes9 commented 1 year ago

Useful resources when considering a pixel perfect vertical spacing scale:

daniellecorke commented 5 months ago

On the UCD Board: https://jira.ons.gov.uk/browse/CU-83.

daniellecorke commented 5 months ago

This issue is currently parked on the UCD Board.