Closed adi-unni closed 4 months ago
Name | Link |
---|---|
Latest commit | 962fbb4c876ecd5008b7fcc1b02b66dec6eb2083 |
Latest deploy log | https://app.netlify.com/sites/ons-design-system-preview/deploys/6630d1ea5ecdfe0008a5a7e2 |
Deploy Preview | https://deploy-preview-3166--ons-design-system-preview.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Can we have a "breaking changes" section added to the description that tells the user how to update their service to fix the breaking change we have introduced
I don't mind if you want to do it in another PR or this one but if we are making this change I think we should also do this for the other params that are named in this way. There is
logoURL
in the header component,overviewURL
in naviagion,pageURL
in share-page but there are others too. These should also be added to the issue.
Added the rest in #3188
Change being completed in #3188
What is the context of this PR?
Fixes: #2138
The page url parameter across the DS was set as
pageUrl
but in share page component waspageURL
. Updating param topageUrl
for consistency.How to review this PR
Check the tests pass and the new param works.
Checklist
This needs to be completed by the person raising the PR.