ONSdigital / design-system

ONS Design System
https://service-manual.ons.gov.uk/design-system
MIT License
31 stars 20 forks source link

Refactor timeline macro to suit Jinja2 templates #3171

Closed SriHV closed 3 weeks ago

SriHV commented 5 months ago

While testing nunjucks files in Jinja Environment(as part of the #3086), few examples showed ‘internal server error’. The main cause of this issue is the differences between Nunjucks (a templating language in JS environments and DS) and Jinja2 (a templating language used by flask in python). Macros need refactoring so it can suit Jinja2 template. This was addressed previously in #3080.

The errors are split up to simplify while refactoring.

components/timeline/example-timeline.njk threw error TypeError: 'builtin_function_or_method' object is not iterable. This is due to items declared is not looped in properly. timeline macro needs to be refactored.