ONSdigital / design-system

ONS Design System
https://service-manual.ons.gov.uk/design-system
MIT License
28 stars 17 forks source link

Refactor document-list macro for compatibility Jinja2 templates #3179

Closed precious-onyenaucheya-ons closed 1 month ago

precious-onyenaucheya-ons commented 1 month ago

What is the context of this PR?

Fixes #3163 Removed .push method which was used for adding file metadata information to a list. This is done to make document list component work with Jinja templates.

How to review this PR

Test the changes in Design system Pull the latest PR (https://github.com/ONSdigital/design-system-python-flask-demo/pull/3) which is in review. Follow the updated readme. Update the macro and test it in Flask.

Checklist

This needs to be completed by the person raising the PR.

netlify[bot] commented 1 month ago

Deploy Preview for ons-design-system-preview ready!

Name Link
Latest commit d4a6a7793a5059f5f809c3e311fbcac46763aed7
Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/663e087f3f7bbe0008796b3d
Deploy Preview https://deploy-preview-3179--ons-design-system-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.