ONSdigital / design-system

ONS Design System
https://service-manual.ons.gov.uk/design-system
MIT License
31 stars 20 forks source link

Update param names to camel case naming standard #3188

Closed rmccar closed 3 weeks ago

rmccar commented 4 months ago

What is the context of this PR?

Fixes: #2138 Updated various params to use the camel case naming standard.

Ive also documented the APIManualQueryParams param on the address input component which was previously undocumented.

BREAKING CHANGE This will be a breaking change and will require the renaming of some params for the following components and params:

How to review this PR

Checklist

This needs to be completed by the person raising the PR.

netlify[bot] commented 4 months ago

Deploy Preview for ons-design-system-preview ready!

Name Link
Latest commit 3626cf88ab0e8cd9e9d013fa082d7ec54adfd370
Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/668e6a6fed5d120008f7664f
Deploy Preview https://deploy-preview-3188--ons-design-system-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rmccar commented 3 months ago

All of the found ones seem good, but I've found some other instances of njk params.

So in address input there's three that start with 'API' "APIDomain": params.APIDomain, "APIDomainBearerToken": params.APIDomainBearerToken, "APIManualQueryParams": params.APIManualQueryParams,

Then it's not a parameter exactly but there's a descriptionID in the label component.

Weirdly messageID is still showing up for me when I look at the branch locally - but I can see the changes when I review the changed documents so I have no idea why that's happening!

These have now been updated