Closed rmccar closed 3 weeks ago
Name | Link |
---|---|
Latest commit | 3626cf88ab0e8cd9e9d013fa082d7ec54adfd370 |
Latest deploy log | https://app.netlify.com/sites/ons-design-system-preview/deploys/668e6a6fed5d120008f7664f |
Deploy Preview | https://deploy-preview-3188--ons-design-system-preview.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
All of the found ones seem good, but I've found some other instances of njk params.
So in address input there's three that start with 'API'
"APIDomain": params.APIDomain, "APIDomainBearerToken": params.APIDomainBearerToken, "APIManualQueryParams": params.APIManualQueryParams,
Then it's not a parameter exactly but there's a descriptionID in the label component.
Weirdly messageID is still showing up for me when I look at the branch locally - but I can see the changes when I review the changed documents so I have no idea why that's happening!
These have now been updated
What is the context of this PR?
Fixes: #2138 Updated various params to use the camel case naming standard.
Ive also documented the
APIManualQueryParams
param on the address input component which was previously undocumented.BREAKING CHANGE This will be a breaking change and will require the renaming of some params for the following components and params:
image.placeholderURL
will need to be renamedimage.placeholderUrl
settingsLinkTextURL
will need to be renamedsettingsLinkTextUrl
logo.logoURL
will need to be renamedlogo.logoUrl
ISOCode
will need to be renamedisoCode
navigation.subNavigation.overviewURL
will need to be renamednavigation.subNavigation.overviewUrl
pageURL
will need to be renamedpageUrl
videoLinkURL
will need to be renamedvideoLinkUrl
assetsURL
will need to be renamedassetsUrl
OGLLink
will need to be renamedoglLink
messageID
will need to be renamedmessageId
maxlength
will need to be renamedmaxLength
APIDomain
will need to be renamedapiDomain
APIDomainBearerToken
will need to be renamedapiDomainBearerToken
APIManualQueryParams
will need to be renamedapiManualQueryParams
errorMessageAPI
will need to be renamederrorMessageApi
errorMessageAPILinkText
will need to be renamederrorMessageApiLinkText
How to review this PR
Checklist
This needs to be completed by the person raising the PR.