ONSdigital / design-system

ONS Design System
https://service-manual.ons.gov.uk/design-system
MIT License
31 stars 21 forks source link

Footer component issues- Royal Coat of Arms #3199

Open daniellecorke opened 6 months ago

daniellecorke commented 6 months ago

Background

We received feedback from the Digital Publishing team about the Footer component in the Service Manual catch up.

Issues

Variant with Royal Coat of Arms

Image

Welsh variant

Image

Tasks

  1. Update the Royal Coat of Arms logo to the digital version SVG provided by Digital Publishing.
  2. Using these guidelines, position the Royal Coat of Arms next to the ONS logo rather than beneath it. Take note of the guidance regarding the clear zone for the logo.
  3. DISCUSS IN REFINEMENT - Identify whether the comparison of the Welsh and English logo font sizes will need to be reviewed by a designer for further advice or can be fixed within the team by a developer. If design work is required, we may need to split this task into another ticket and take it to the UCD Team for advice first.
daniellecorke commented 6 months ago

I've contacted Grace to confirm feedback for the footer component. On hold whilst awaiting a response.

daniellecorke commented 5 months ago

Discussed with Grace and updated the ticket to reflect. Grace will provide the correct SVG logo - once this is received this ticket can be taken off hold.

e-livingstone commented 3 months ago

Followed up with Grace for a copy of the SVG logo

e-livingstone commented 3 months ago

From Grace:

Please find attached a SVG of the Royal Coat of Arms logo. This version of the logo should be no bigger than 20mm in width

Looking at the brand guidelines (linked in the description) the digital / simplified version of the logo should be no smaller 26 pixels wide and no larger than 56px wide. The clear zone around the logo is the width of the logo.

Image

e-livingstone commented 3 months ago

Question from refinement: are we supporting 2 side-by-side logos plus the crest or does the crest count as the second of 2 side-by-side logos. @MagdalenaLarge to get input from Grace and UCD - i.e. what happens to position of logos when the split variant is used (not yet released).

MagdalenaLarge commented 3 months ago

@e-livingstone I had a chat with Joe about the potential solutions. He suggested that we could:

1/ build ONS logo + crest as one logo as one of the variants. This way we could still have 2 logos on the website, including the split logos. 2/ create 4 columns for 3 logos: ONS logo (1), crest (2), blank space (3) and 2nd logo (4). This way we would achieve split logos but also have ONS logo & crest as elements.

Both above needs to be tested on the mobile version to ensure they are presented correctly to the user.

Regarding the size of the ONS Logo versus crest, he suggested to use stacked ONS logo as it is currently on ONS website:

Image

@alessioventuriniAND @rmccar @precious-onyenaucheya-ons - could you please discuss on the next tech session what is doable and let us know the effort needed from the development point of view. Thanks

MagdalenaLarge commented 2 months ago

Discuss with @JNATION85 and Grace Elins if we still need this component and if yes, what are the rules of using it (they need to be added to Service Manual).

MagdalenaLarge commented 1 month ago

Contacted Grace Elins and asked for the rules of using the Royal Coat of Armour. If we keep it in DS, we will need clear description in Service Manual how it can be used. Other option is to remove this logo from the DS.