ONSdigital / design-system

ONS Design System

https://service-manual.ons.gov.uk/design-system

MIT License

27 stars 17 forks source link

Changed PoweredBy param to include a link #3201

Closed SriHV closed 3 weeks ago

SriHV commented 1 month ago

What is the context of this PR?

3164... Previously, there was no option to include a link around poweredBy logo when custom logo was used. Changed poweredBy param to include this.

How to review this PR

Check that poweredBy param has two parameters logoImage and logoUrl. Test example-footer-with-alternative-organisation to ensure these parameters are shown

Checklist

This needs to be completed by the person raising the PR.

[x] I have selected the correct Assignee
[x] I have linked the correct Issue

netlify[bot] commented 1 month ago

Deploy Preview for ons-design-system-preview ready!

Name	Link
Latest commit	378586d023c3015a555d64d6eb0fe808c41cec47
Latest deploy log	https://app.netlify.com/sites/ons-design-system-preview/deploys/66605bf85c1a540008f2bc87
Deploy Preview	https://deploy-preview-3201--ons-design-system-preview.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

balibirchlee commented 1 month ago

Not sure how this fits together with the changes Precious made to the poweredby functionality recently - I think we'll need to discuss in the next tech session.

SriHV commented 3 weeks ago

This change is already being addressed in this #3134 PR. Closing this ticket