ONSdigital / design-system

ONS Design System
https://service-manual.ons.gov.uk/design-system
MIT License
27 stars 17 forks source link

Add "Tech improvements" label to label checker #3203

Closed rmccar closed 1 month ago

rmccar commented 1 month ago

What is the context of this PR?

Fixes: #3184

This PR adds the "Tech improvements" label which can be used for tech debt and small technical improvements

How to review this PR

Check that change makes sense

Checklist

This needs to be completed by the person raising the PR.

netlify[bot] commented 1 month ago

Deploy Preview for ons-design-system-preview ready!

Name Link
Latest commit 2c381d240369be1864fa8f050a3c3263bf62c897
Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/66423660bd75260008ddd22f
Deploy Preview https://deploy-preview-3203--ons-design-system-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

balibirchlee commented 1 month ago

Am I right that enhancements effect the functionality whilst tech improvements don't?

Also wouldn't mind discussing the purpose and use of labels in a tech session, especially in relation to some of the research I've been doing (similar to types from conventional commits)

But this is just me trying to better understand it all!

rmccar commented 1 month ago

Am I right that enhancements effect the functionality whilst tech improvements don't?

Also wouldn't mind discussing the purpose and use of labels in a tech session, especially in relation to some of the research I've been doing (similar to types from conventional commits)

But this is just me trying to better understand it all!

Yeah pretty much, I would say enhancements add or improve functionality from a user perspective but tech improvements don't really make a difference to the user and are more like tech debt. But yeah I think it would be good to discuss these labels and what sections we want them to go into in the release documentation etc as part of the work you are doing.