ONSdigital / design-system

ONS Design System
https://service-manual.ons.gov.uk/design-system
MIT License
27 stars 17 forks source link

Focus state on neutral header variant is not accessible #3204

Open daniellecorke opened 1 month ago

daniellecorke commented 1 month ago

Background/Issue

Several issues with the Neutral header for multi-coloured brand logo variant have been identified.

  1. The focus state for the links in the Neutral header is not accessible. The text is supposed to be black and not white.

Image

  1. Some items have a double line when focused and others have one. The ONS logo cannot be seen when in focus state. We do not display the submenu in the example.

Image

Tasks

This ticket covers fixing the bugs highlighted in the ticket. Further discussions are required to discuss a full re-design of the Header component.

  1. Ensure that text in focus state is black.
  2. Ensure that one single line is displayed in focus state.
  3. Ensure that the ONS logo can be displayed in focus state.

Acceptance Criteria

If possible, each bug is fixed and tested.

SriHV commented 1 month ago

Had a chat with @JNATION85. We are doubtful above the use case of Neutral header for multi-coloured brand logo and hover line when focussed(hover line turns to white instead of black, this however blends with the header with the current styling) which needs further discussion.

SriHV commented 1 week ago

After conversations with Dina and Joe following changes were made in this ticket: