Closed balibirchlee closed 4 weeks ago
Name | Link |
---|---|
Latest commit | 82ceedbd74330893f0d5cde44f2c73c5355b18f4 |
Latest deploy log | https://app.netlify.com/sites/ons-design-system-preview/deploys/665dbb6f0611c20008881d3d |
Deploy Preview | https://deploy-preview-3212--ons-design-system-preview.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
What is the context of this PR?
Fixes: #3181
Details of changes:
Reasoning for decisions:
min-width
rather thanwidth
to prevent it restricting the size of the feedback patterns which are wider than 25rem.:has(select)
to identify when a radio/checkbox has a hidden select component, then uses:first-child
to ensure it's only set on one parent element of that select, rather than all of them (which creates visual errors).Relevant issues/discussions:
How to review this PR
Visual inspection: Components/Patterns to Check
Actions
Desired Behaviour
Relevant tests:
Special attention:
Checklist
This needs to be completed by the person raising the PR.