ONSdigital / design-system

ONS Design System
https://service-manual.ons.gov.uk/design-system
MIT License
27 stars 17 forks source link

Rename summary component parameters #3224

Open precious-onyenaucheya-ons opened 1 month ago

precious-onyenaucheya-ons commented 1 month ago

What is the context of this PR?

BREAKING CHANGE Fixes #3229

In this PR, we are addressing an inconsistency in the naming of parameters within the summary component. This change aims to standardize the parameter names for clarity and consistency.

The following parameter renames are included:

This change is a breaking change because it alters the existing parameter names, which will require updates wherever these parameters are used .

How to Review this PR

  1. Ensure all instances of the renamed parameters have been updated throughout the codebase.
  2. Verify that the summary component works correctly after these changes.
  3. Run all tests to ensure no functionality is broken by this update.

Checklist

This needs to be completed by the person raising the PR.

netlify[bot] commented 1 month ago

Deploy Preview for ons-design-system-preview ready!

Name Link
Latest commit d29e11e812ae9921902e8999e90d4260f8177d53
Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/66752b5b54e192000965b68e
Deploy Preview https://deploy-preview-3224--ons-design-system-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

precious-onyenaucheya-ons commented 3 weeks ago

Should we also replace rowItems with just items?

updated