ONSdigital / design-system

ONS Design System
https://service-manual.ons.gov.uk/design-system
MIT License
27 stars 17 forks source link

Feature/3134 add option for additional logo in footer #3227

Open precious-onyenaucheya-ons opened 4 weeks ago

precious-onyenaucheya-ons commented 4 weeks ago

What is the context of this PR?

Fixes #3134 This PR updates the footer component to support an additional logo, allowing for two logos instead of just one. It introduces link param for each logo and offers an alternative layout option to display the logos on opposite sides of the footer. The default layout positions the logos next to each other. Additionally, the implementation is aligned with the header component's multipleLogo feature to ensure consistency across the application. The focus and hover states are also adjusted to avoid extra underlines and to ensure the highlight color wraps only the SVG.

BREAKING CHANGE Services using the poweredBy param with the footer component will now need to update that param to footerLogo object in their config.

How to review this PR

Checklist

This needs to be completed by the person raising the PR.

netlify[bot] commented 4 weeks ago

Deploy Preview for ons-design-system-preview ready!

Name Link
Latest commit 23fd37ce3a7c1c231f308a972345bceb32b8b77c
Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/6683165e3939210008e54aeb
Deploy Preview https://deploy-preview-3227--ons-design-system-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

balibirchlee commented 2 weeks ago

I thought that we were wanting to rename 'poweredby' - and follow the naming convention of the header section with the logo1 logo2 rather than 'additionalPoweredByLogo'. Given that the functionality has come from the team, having it as a breaking change / incorporating it into plans for deprecation makes more sense to me, as there's no external pressure for it to be merged asap - I worry about creating more tech debt

precious-onyenaucheya-ons commented 2 weeks ago

@rmccar Previously, a margin-bottom was set for the default ONS logo if no powered-by logo was provided. However, if a powered-by logo was included, there was no margin-bottom. The difference in the snapshot is due to my adjustment: I have added the margin-bottom to be consistently applied in both scenarios.

SriHV commented 1 week ago

In the example-footer-with-alternative-organisation one, the logo is not focused right. Can you check this? Screenshot 2024-06-19 at 14 49 31