ONSdigital / design-system

ONS Design System
https://service-manual.ons.gov.uk/design-system
MIT License
27 stars 17 forks source link

Refactor social list variant adding correct CSS automatically #3245

Open rmccar opened 5 days ago

rmccar commented 5 days ago

Would be a good idea to refactor the social list variant so that the css that is related to it is set automatically when using a social icon. Currently some examples using them have this set and some not so there is some inconsistencies. This will also make the config a bit simpler for the user they will just need to set the icon and the rest will take care of itself. I don't think this ever should've been a variant as the css is mandatory to get the alignment of the text right when using the social icons and is not really a list variant more that when using one of the social icons instead of any other icon we need to align the text so this is why I think it would be good to set this automatically for the user.

The changes that need to be made have been reverted in this commit