Closed rmccar closed 1 week ago
Name | Link |
---|---|
Latest commit | 9551b0121950587ec94cc2c6c310240e4180d99f |
Latest deploy log | https://app.netlify.com/sites/ons-design-system-preview/deploys/672e7e15cb037c000841ccc4 |
Deploy Preview | https://deploy-preview-3414--ons-design-system-preview.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
What is the context of this PR?
Fixes: #3401
Added awaits to some of the expects that are causing some flakiness on the autosuggest and upped a wait on the modal tests. I have now run the tests 10 times in a row and they passed every time which you can see in the test attempts in the GitHub action below. I think if we continue to see flakiness after this PR has been merged we should revisit this again.
How to review this PR
Check the macro test logs for the last commit where I made changes rather than the merging in main commits (https://github.com/ONSdigital/design-system/actions/runs/11631038531/job/32395239872?pr=3414) to see that the tests have been run 10 times and passed every time.
Checklist
This needs to be completed by the person raising the PR.