ONSdigital / design-system

ONS Design System
https://service-manual.ons.gov.uk/design-system
MIT License
31 stars 21 forks source link

Fix button logic for when `noIcon` param is set to false #3418

Closed rmccar closed 1 week ago

rmccar commented 1 week ago

What is the context of this PR?

Fixes: #3417

Fixes the logic around the noIcon param so that it does show the arrow icon on link buttons when noIcon is set to false.

How to review this PR

Test using the button component with url set and noIcon set to true and false, and without being set at all and see that the arrow icon is displayed for when it is set to false or not set and not displayed when it is set to true

Checklist

This needs to be completed by the person raising the PR.

netlify[bot] commented 1 week ago

Deploy Preview for ons-design-system-preview ready!

Name Link
Latest commit dd39292fb3b24374392394db214a2c68d0bf15bf
Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/673320f895c3130008a88dfa
Deploy Preview https://deploy-preview-3418--ons-design-system-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.