ONSdigital / design-team

An empty repository as the hub for design team tickets (Issues).
0 stars 0 forks source link

Check and update the components which setting a custom line height to match new standard #75

Open MagdalenaLarge opened 3 months ago

MagdalenaLarge commented 3 months ago

As Interaction Designer I want have the consistency across all components regarding size So that user can have the best experience using ONS website

Description We identified that some components are setting custom line height for text (for example Button) which do not sit in 8 pix grid standard which we are going to implement. This need to be changed.

Acceptance Criteria

  1. Identify all components which have non standard line height
  2. Non standard utility class is matching 8 pix grid
  3. User has the same experience on both types of the devices: desktop and mobile.

Visualisation/Input from UCD How should the components look like?

Linked User stories/epics Issue linked to change of utility classes to 8 pix grid

Technical details

The line height set by some components individually needs to adhere to the line height of the text and not set their own custom value.

MVP (optional)

MagdalenaLarge commented 3 months ago

Screenshot 2024-07-12 at 10 07 26 For the reference please use the above Typography details prepared by Interaction Designers.

MagdalenaLarge commented 3 months ago

Clarification from Dina

Image

e-livingstone commented 3 months ago

Blocked - dependent on solution for #69

alessioventuriniAND commented 2 months ago

All the component that had custom line-height set have been edited to either remove unnecessary line height or align their line height with our new spacing grid. This work has been completed as part of #69.