Adds 3 new functions for error messages and unit tests for each one checking the returned message contents.
How to review
Check that the error messages are sensible and contain reasonable details on the errors. Check that the tests are making the right assertions/checks.
Please let me know what your thoughts are on my use of local_path in the message text. I could not think of a way to use the input store otherwise to add detail to the message, but local_path depends on LocalDirectoryStore which is an implementation of BaseWritableDirectoryStore. If I shouldn't use that here I am happy to change it.
What
Adds 3 new functions for error messages and unit tests for each one checking the returned message contents.
How to review
Check that the error messages are sensible and contain reasonable details on the errors. Check that the tests are making the right assertions/checks.
Please let me know what your thoughts are on my use of local_path in the message text. I could not think of a way to use the input store otherwise to add detail to the message, but local_path depends on
LocalDirectoryStorewhich is an implementation ofBaseWritableDirectoryStore. If I shouldn't use that here I am happy to change it.Who can review
Anyone.