search

ONSdigital / dp-data-pipelines

Pipeline specific python scripts and tooling for automated website data ingress.
MIT License
1 stars 0 forks source link

Acceptance tests working #66

Closed SarahJohnsonONS closed 5 months ago

SarahJohnsonONS commented 5 months ago

What

environment.py - sets up a docker container to run the Flask app required to route requests sent as part of acceptance test scenarios. Container is stopped and removed once all the tests have finished running. Dockerfile and app.py in features/docker/fake_backend.

temporary.feature - contains three acceptance tests with different inputs.

temporary.py - step definitions required to run the tests in temporary.feature, and some utility functions for parsing docker logs.

How to review

Sanity check, make sure you can run the acceptence tests by running behave in the repo root directory. I've added a logs.txt file showing the content of the docker logs for the three scenarios - suggestions for making these more useful welcome.

Who can review

Anyone.

SarahJohnsonONS commented 5 months ago

minor comments, but can you also update make install to install the poetry dev dependencies then add a make feature command that runs it before calling behave.

make install currently runs poetry install, which I thought installed all dependencies, including dev ones?