dont just copy it, im repeating msyelf with checking the env var.
also, we need a test
also (ideally) we can do it with a decorator still, but the decorator is designed to work with a function that returns a string, not a method that sends a message.
you'll need to play, the decorator would be nice, but we can live with doing it some other sensible way if that doesn't make sense and/or gets messy.
Acceptance Criteria
[ ] Success/fail messages sent by the pipelines should have the contents of the ENRICH_OUTGOING_MESSAGES env var appended to them.
What is this
Currently the
enrich_online
decorator is decorating messages to have the url of the glue job after them.but.... we're no longer sending those messages to slack, so we get a tick or boom followed by no url.
for the demo I just threw a quick hack onto a branch and deployed that, this task is to do it properly.
What to do
this is the quick hack code: https://github.com/ONSdigital/dp-data-pipelines/compare/sandbox...enrich-pass-fail-notifications
you'll need to play, the decorator would be nice, but we can live with doing it some other sensible way if that doesn't make sense and/or gets messy.
Acceptance Criteria