ONSdigital / dp-data-pipelines

Pipeline specific python scripts and tooling for automated website data ingress.
MIT License
1 stars 0 forks source link

add success/fail url postfix #86

Closed mikeAdamss closed 4 months ago

mikeAdamss commented 5 months ago

What is this

Currently the enrich_online decorator is decorating messages to have the url of the glue job after them.

but.... we're no longer sending those messages to slack, so we get a tick or boom followed by no url.

for the demo I just threw a quick hack onto a branch and deployed that, this task is to do it properly.

What to do

this is the quick hack code: https://github.com/ONSdigital/dp-data-pipelines/compare/sandbox...enrich-pass-fail-notifications

you'll need to play, the decorator would be nice, but we can live with doing it some other sensible way if that doesn't make sense and/or gets messy.

Acceptance Criteria

mikeAdamss commented 4 months ago

done