I've changed the nomanclature to "Notifier" over "Messenger" as its just pass/fail notifications now.
I've created a BasePipelineNotifier base class with two implementations:
PipelineNotifier - the normal behaviour
NopNotifier (NOP - non operational). Which has empty methods so will satisfy the code while not actually sending any notifications.
There;'s a function which decides which one you've instantiated based on the DISABLE_NOTIFICATIONS env var.
Ran fmt and lint to tidy up the codebase so there's quite a lot of noise here. To stop this from happening all the time I've added a github action to run everything on push to branches (for now, we should really be using concourse).
What
Allow a developer to disable notifications to slack while developing by using the
DISABLE_NOTIFICATIONSenv var. This task: https://github.com/ONSdigital/dp-data-pipelines/issues/49I've changed the nomanclature to "Notifier" over "Messenger" as its just pass/fail notifications now.
I've created a BasePipelineNotifier base class with two implementations:
There;'s a function which decides which one you've instantiated based on the
DISABLE_NOTIFICATIONSenv var.Ran
fmtandlintto tidy up the codebase so there's quite a lot of noise here. To stop this from happening all the time I've added a github action to run everything on push to branches (for now, we should really be using concourse).How to review
Try it out. Sanity check.
Who can review
Anyone.