ONSdigital / dp-design-system

Design System for Digital Publishing
MIT License
6 stars 3 forks source link

Update data aggregation #206

Closed StRhys closed 7 months ago

StRhys commented 8 months ago

What Reworks this pr that was causing issues with pagination.

How to review Sense check it Pull this branch, run dp-frontend-search-controller using make debug ENABLE_REWORKED_DATA_AGGREGATION_PAGES=true, port forward the api router to sandbox dp ssh sandbox web 1 -p 23200:localhost:10800, head other to http://localhost:25000/timeseriestool, play with the 'last updated' dropdown.

Who can review frontend

lindenmckenzie commented 7 months ago

Could you be a bit more specific about the problem you were trying to solve here?

I've had a good play locally and I think there are some edges cases not accounted for (may not be JS specific)

I can see that clearing the input now clears the params which is good.

However there's a lot of strange edge behaviour when moving between the pre-configured ones and the 'custom' selection. Might it just be easier to nuke the 'last update' and just have the custom selection?

example path:

another example path: