ONSdigital / dp-find-insights-poc-api

Find Insights Proof of Concept
MIT License
1 stars 0 forks source link

Feature/ckmeans ratio endpoint #159

Closed VivianAllen closed 2 years ago

VivianAllen commented 2 years ago

What

commit 1d19138c32fbbbbe47e7fade57a46a92d98a14cf (HEAD -> feature/ckmeans-ratio-endpoint, origin/feature/ckmeans-ratio-endpoint) Author: Vivian Allen vivian.allen@methods.co.uk Date: Tue Jan 18 15:52:26 2022 +0000

add swagger + handlers for ckmeansratio endpoint

Add swagger definition, auto-generated code, and handlers
for ckmeansratio endpoint.

commit 5a0f06d9af2355c8c97eeaf3fff6dc7d46de69c5 Author: Vivian Allen vivian.allen@methods.co.uk Date: Tue Jan 18 15:48:17 2022 +0000

add CKmeansRatio function to geodata

geodata.CKmeansRatio does the same ckmeans data breaks calculation
as geodata.CKmeans, except that it takes two category arguments,
and will do ckmeans breaks for the ratio category1/category2.

Refactored CKmeans to avoid duplicate code where possible.

These changes needed to allow API consumers to get data breaks
for dimensionless data derived from raw data.

commit 754ef80a6647fade23ef25fcdedc76eea56fe2ee Author: Vivian Allen vivian.allen@methods.co.uk Date: Tue Jan 18 15:47:44 2022 +0000

Add verbose make rule make test-comptestv

commit 7172ca912d3e8b58c0a547c7553117099086e17e Author: Vivian Allen vivian.allen@methods.co.uk Date: Tue Jan 18 15:45:33 2022 +0000

use comptests.DefaultDSN in metadata_test component test

Use the DefaultDSN to avoid issues where different component tests
think the test database is on different ports

commit 5f620315b97f2402c224797bebd10761428eb5cb Author: Vivian Allen vivian.allen@methods.co.uk Date: Tue Jan 18 15:42:47 2022 +0000

fix rowquery_test + add comptest utils and geodata comptest runner

- add comptest_runner_test.go to manage common setup and teardown
for component tests in geodata
- move common component test code to comptests/utils.go
- fix missing fk bug in geodata/rowquery_test.go component test

These changes needed to allow multiple component test files in the
same package.

How to review

Read the code pull locally and run make test-comptest to make sure tests pass

Who can review

anyone