ONSdigital / dp-find-insights-poc-api

Find Insights Proof of Concept
MIT License
1 stars 0 forks source link

Add default $POSTGRES_PASSWORD to setup for comptests #195

Closed VivianAllen closed 2 years ago

VivianAllen commented 2 years ago

What

Extend comptests/docker.go to use a default value for the $POSTGRES_PASSWORD env var if it is not set (in this case, the default value will be used on the go code AND set as an env var for docker to pickup).

This change needed to allow comptests to run without setting up the env first.

How to review

unset POSTGRES_PASSWORD
docker kill postgis
make test-comptest 

Comptests should start up a new postgis in docker and run ok, even without a POSTGRES_PASSWORD value in the env

Who can review

Describe who worked on the changes, so that other people can review.