ONSdigital / dp-find-insights-poc-api

Find Insights Proof of Concept
MIT License
1 stars 0 forks source link

Feature/additional integration tests #43

Closed VivianAllen closed 2 years ago

VivianAllen commented 2 years ago

What

commit b253a148c360a885ef3146c4ad3f69493a790ff0 (HEAD -> feature/additional-integration-tests, origin/feature/additional-integration-tests) Author: Vivian Allen vivian.allen@methods.co.uk Date: Thu Nov 18 14:40:17 2021 +0000

inttests check for 200 status in API response

commit 7d97e923534a4a737acc1fb6611e70833af71d2e Author: Vivian Allen vivian.allen@methods.co.uk Date: Thu Nov 18 14:30:40 2021 +0000

handle missing/multiple resp files in integration regression tests

Add code to fail test and suggest re-run of main.go if no or
multiple response files are found for API regression tests.

commit 2fcace8e3d86420015673ebb1c7102993c65432f Author: Vivian Allen vivian.allen@methods.co.uk Date: Thu Nov 18 12:20:45 2021 +0000

more integration test cases

Add more API queries to integration test cases arrays. These
changes needed to ensure full range of API behaviour is covered.

commit ec7805afb6a441fd551f75c0b124d2dcfa06a426 Author: Vivian Allen vivian.allen@methods.co.uk Date: Thu Nov 18 09:15:00 2021 +0000

inttests regresssion tests store test desc in resp filename

Refactor inttests/main.go and main_test.go so that the test
description is part of the filename (in addition to the files
sha1 hash) for the response files used to check regression.

New test cases for which there is no repsonse file will
always fail, and will prompt you to re-run main.go to record
the response file.

This change needed for easier maintenance.

How to review

eyeball code run tests

Who can review

anyone