I have slightly renamed the functions as this way makes more sense (an "s3 object" isn't a file, its more metadata-y - this way makes more sense to me though opinions welcomed).
I also added a Makefile while I was in there for convenience.
How to review
to run the tests:
pipenv sync --dev
make test.
Also, sanity check the code and make sure the readme makes sense to you.
What
Just finishing up Mo's work on the initial s3 functions ticket: https://github.com/ONSdigital/dp-python-tools/issues/4
I have slightly renamed the functions as this way makes more sense (an "s3 object" isn't a file, its more metadata-y - this way makes more sense to me though opinions welcomed).
I also added a Makefile while I was in there for convenience.
How to review
to run the tests:
pipenv sync --devmake test.Also, sanity check the code and make sure the readme makes sense to you.
Who can review
Anyone