ONSdigital / dp-python-tools

Simple reusable python resources for digital publishing.
MIT License
1 stars 0 forks source link

Base directory store #18

Closed NickPapONS closed 9 months ago

NickPapONS commented 9 months ago

What

Implementing the base classes BaseReadableSingleDirectoryStore and BaseWritableSingleDirectoryStore, then the LocalDirectoryStore class. For now, most of the methods of the class are abstract only and do not have concrete implementations. Added unit tests to test the instantiation and validation of LocalDirectoryStore.

How to review

Check that the base classes transferred over looks alright and their directory/file structure makes sense. Check local.py to see if it addresses all the required points of the ticket and that it stores the Path of the given directory properly. Check the unit tests to see if they cover everything added so far for the LocalDirectoryStore class.

Who can review

Anyone.