search

ONSdigital / dp-python-tools

Simple reusable python resources for digital publishing.
MIT License
1 stars 0 forks source link

Decompress from s3 #26

Closed mikeAdamss closed 6 months ago

mikeAdamss commented 7 months ago

What

Function for decompressing from s3. Minor changes from card as the tar library we're using raises errors should you try and overwrite an existing file - not having to care about the output path existing simplifies the directory/target logic significantly.

Note - If you've looked at this previously, I've also switched to using a tempfile download and the download function rather than the get object function as this enabled use of moto in the unit tests.

There is a fair bit of extra formatting included in these changes from make fmt. Also removed some unused imports highlighted by make lint.

How to review

Sanity check the code, try it out, make sure the readme makes sense to you.

Who can review

Anyone,.

mikeAdamss commented 6 months ago

closing for unverified commits, code was merged elsewhere.