Additional mandatory fields added to Upload Service upload-new endpoint. There's still an issue with the Path parameter, but this is due to a potential problem in the Go code (see comment in dpytools/http/upload.py L283-285). This issue has been reported to relevant tech leads for investigation.
How to review
Hard to test due to the issue mentioned above, but check that all of the fields in Resumable and FileMetadata structs are being added to the request parameters. Use a file that's bigger than 5MB so that you can check it's generating the correct parameters for each chunk.
What
Additional mandatory fields added to Upload Service
upload-new
endpoint. There's still an issue with thePath
parameter, but this is due to a potential problem in the Go code (see comment indpytools/http/upload.py
L283-285). This issue has been reported to relevant tech leads for investigation.How to review
Hard to test due to the issue mentioned above, but check that all of the fields in
Resumable
andFileMetadata
structs are being added to the request parameters. Use a file that's bigger than 5MB so that you can check it's generating the correct parameters for each chunk.Who can review
Anyone.