search

ONSdigital / ons-python-template

A basic Python template to jump start a Python project
MIT License
3 stars 2 forks source link

Add Pylint command to jinja template #71

Open evisos-ons opened 6 days ago

evisos-ons commented 6 days ago

What is the context of this PR?

Pylint is mentioned in the README.md but not implemented in the MAKEFILE of the template and when the template is used, evident in the demo.

How to review

Pull changes, use template, run make lint to run black, ruff, mypy and pylint.

evisos-ons commented 6 days ago

Addition to PR

After using the template on another repository, when using make lint, the black and ruff sub-commands run but the pylint and mypy sub-commands don't as the ruff sub-command returns an error:

make: *** [<command>] Error

Adding in <command> || true to here ensures the subsequent sub-commands run when using the make lint command.