search

ONSdigital / sdc-global-design-patterns

The SDC Global Design Pattern library. Used as the basis for SDC projects. Outputs to CDN for use in production and development projects, documentation publishes to netlify.
https://sdc-global-design-patterns.netlify.com/
11 stars 2 forks source link

Authenticating with GitHub to increase API limit #140

Open MebinAbraham opened 6 years ago

MebinAbraham commented 6 years ago

GitHub's rate limit caused pattern lib relase to S3 fail. http://concourse.dev.eq.ons.digital/teams/main/pipelines/sdc-global-design-patterns/jobs/Release/builds/61

Actual behaviour

error running command: GET https://api.github.com/repos/ONSdigital/sdc-global-design-patterns/releases/11960728/assets: 403 API rate limit of 60 still exceeded until 2018-07-27 09:29:13 +0000 UTC, not making remote request.; rate reset in 1m22.263560553s

Need to make use of keys to increase the allowed API calls. https://developer.github.com/v3/#increasing-the-unauthenticated-rate-limit-for-oauth-applications

armstrongb commented 6 years ago

@jonnyshaw89 is this something that you could look at?

jonnyshaw89 commented 6 years ago

@armstrongb Are we still seeing this?

armstrongb commented 6 years ago

@jonnyshaw89 I will check on next deploy - this one failed because the build hadn't completed before the tag was released.