search

ONSdigital / sdc-global-design-patterns

The SDC Global Design Pattern library. Used as the basis for SDC projects. Outputs to CDN for use in production and development projects, documentation publishes to netlify.
https://sdc-global-design-patterns.netlify.com/
11 stars 2 forks source link

Automated cross browser testing #211

Closed saedwards closed 5 years ago

saedwards commented 5 years ago

What is the context of this PR?

Describe what you have changed and why, link to other PRs or Issues as appropriate.

How to review

Describe the steps required to test the changes (include screenshots if appropriate).

armstrongb commented 5 years ago

@saedwards looking good - all tests passed 👍 what's next?

saedwards commented 5 years ago

@saedwards looking good - all tests passed 👍 what's next?

I'm configuring Karma locally but run into usage problems. Browser Stack is giving me the following error with our paid license: 'Error: Your free access to test on real devices has expired. You can upgrade to the Automate Mobile plan to test on real devices. Please reach out to our Sales team at sales@browserstack.com.'

I've contacted them regarding this.

saedwards commented 5 years ago

After Karma is configured with the right browsers, we'll be looking to increase our code coverage, otherwise we'll still get problems. Each developer should write tests for their code (old and new components).