Closed brockfanning closed 3 years ago
@phillipgardiner @brockfanning feature branch: http://uk-sdg-feature-branches.s3-website.eu-west-2.amazonaws.com/feature-site-cookies-gds-npm/
@LucyGwilliamAdmin There's an issue with the downloading of the font - I didn't think about the different subfolder on the feature branch. Can you make this change in your branch? Change this line to:
$govuk-assets-path: "/feature-site-cookies-gds-npm/assets/";
@brockfanning, thanks I've just made that change - I think it's downloading now?
Yep, looks good.
@brockfanning @LucyGwilliamAdmin @AnnCorp I'm very pro using the transport font. However this would require some tweaking to the font sizes used for certain apsects of the site. For example using a 16px for the main body text is too small, this would need to be at least 18px. There are others too, again GDS do have recommendations of what to use. If we go ahead with this perhaps we need another tickets font size changes, I could then work out what needs to change to what?
@brockfanning @LucyGwilliamAdmin @AnnCorp Looking through the rest of the cookies pages etc, I think we are going to have to do my above comment (change our body text to use 'gov-body') As we are now using standard GDS components in some instances, they automatically set the font size for these elements (which is 19px, govuk-body). It therefore then looks odd when we have our body text size 16px and then the GDS component uses 19px as standard.
@brockfanning is the cookie bits finished and ready for me to take a look at properly now and provide any feedback?
@phillipgardiner That makes sense. I can look into adding that body class, as that seems like it should be fairly easy. Also yes, the cookie bits are ready to review in the meantime.
@brockfanning this is looking REALLY good, couple of things I've spotted.
That's it I think, good work :)
@brockfanning sorry one more. When javascript is turned off and a user clicks the cookie link in the footer they should be taken to an alternative page, as show on page 3 of this document Cookies_Page_v3.pdf
@phillipgardiner Regarding no. 5, since the code needs to be HTML, it's not possible to copy/paste the whole thing in bulk. I would need to copy/paste each individual paragraph/cell/etc. So if it's not too much trouble then it might be more efficient if you could point out the specific changes needed - or summarize them (eg, "all the descriptions of the hotjar cookies", etc.). I started by copying what is already on the published cookies page.
Regarding the font sizes, I misunderstood before. I was thinking we could add a single class to the <body>
element, but now I see that we would need to add classes to individual elements. (This is what I was referring to before about needing to "rewrite all the markup".) I think for now it will actually be simplest to mimic the GDS font sizes element-by-element, using custom CSS. I can start with the ones you've mentioned already. By the way, I also wanted to make clear: if you want to split out the font change to another ticket, that is perfectly doable. Either way is fine with me -- it's totally up to you. If we did split it out, then we would need to first complete this cookies ticket before going on to the font change.
Regarding the no-javascript content for the cookies page, that is actually quite tricky. What would be much simpler would be to display the no-javascript content at the top, in addition to the normal content. Ie:
My page heading
My no-javascript content...
My normal content...
It's much trickier to actually hide content when javascript is turned off:
My page heading
My no-javascript content...
I say "tricky" because it's not impossible, but it definitely increases the complexity, which increases your maintenance burden. So I wanted to alert you of this in case the simpler approach is acceptable.
That's all the content changes, I will update you with font feedback shortly - thanks
@brockfanning basing on mimicking the GDS font sizes element-by-element. On the basis of getting close but still keeping the hierarchy of our pages these are the ones so far. There is quite a few! I'd need to have another look once done to see if I missed anything. Perhaps it is worth discussing on the tech call tomorrow this approach verses delaying the use of the transport font? (I'm not sure how much effort these listed changes will be, against needing to make the cookies page patterns implemented match our norm text style. However if we delay the use of transport font I think we may need to increase the size of our Helvetica body text anyhow as it appears smaller than Open sans.
@brockfanning @AnnCorp Regarding the no-javascript content for the cookies page. We had a quick catch up about this in one of our other team meetings. @brockfanning Would you be able to unpick this a bit more and bring along a rough idea of effort and subsequent ramifications of each option to the tech call tomorrow for Ann to make a decision - thanks
@LucyGwilliamAdmin This is ready for a refresh for more review.
@phillipgardiner I believe I've addressed all of the items mentioned so far. A few notes:
Discussed in tech call: we'll split the font change into a separate ticket to be done after this one.
@LucyGwilliamAdmin This is ready for another refresh, now that the font changes have been postponed to a later ticket.
@brockfanning @phillipgardiner feature branch has been refreshed: http://uk-sdg-feature-branches.s3-website.eu-west-2.amazonaws.com/feature-site-cookies-gds-npm
@phillipgardiner Since that feature branches demonstrates the "simple" no-javascript approach (where the no-javascript alert is shown in addition to the regular stuff), I'll also describe the likely approach for a "less simple" no-javascript approach:
Then the two pages would be maintained separately and could have separate content. I thought I would explain that to show that it's not impossible, just slightly more complicated. Either way is fine with me.
@brockfanning thanks for making all those changes. I've doubled checked them and they all look great. In regard to the other bits mentioned:
@brockfanning @AnnCorp regarding the no-javascript journey, my preference is for the latter option (e.g. separate page) as its driven by GDS research and also used on ons.gov.uk, and the census websites so keeps the experience consistent. But ultimately i'll leave the call to @AnnCorp. I'm guessing it would be an if statement type thing: If JS = on then display page A, If JS = off, then display page B.
Thanks for doing all this, its looking great.
@brockfanning I agree with @phillipgardiner re approach for no-javascript journey as that is the approach GDS research supports and for UK users to have consistent experience.
@brockfanning if I send doc over slack, can you include privacy policy commit in this PR please?
@brockfanning @LucyGwilliamAdmin could we please add the 'Privacy' link between 'Cookies' and 'Accessibility statement' in the footer - thanks
@LucyGwilliamAdmin This is ready for a refresh.
@phillipgardiner You'll notice that I had to re-word the no-javascript language. Because of the approach we're using (a separate "cookies-no-javascript" page) just "reloading the page" or "turning on javascript" is not enough -- that would just refresh the same no-javascript page. What is needed is for the user to click again on a "Cookies" link.
Also, it is possible distinguish between the different scenarios:
So rather than listing both 1 and 2, I have the no-javascript message only showing the appropriate one.
@phillipgardiner Scratch that last comment, I thought of a way to use the original language, by adding a javascript redirect from cookies-no-javascript to cookies.
@brockfanning @phillipgardiner feature branch has been refreshed
@brockfanning @LucyGwilliamAdmin thanks both
Couple of new bits of feedback spotted:
In regards to the privacy notice
Thanks
@brockfanning @phillipgardiner My bad with the privacy page - it looked fine on my preview but I must not have formatted it correctly. I think possibly an extra line needs to be added in some places? I think the weird indention also might be fixed by this.
@LucyGwilliamAdmin thats fine, if I can help in anyway let me know :)
@LucyGwilliamAdmin The branch is ready for a refresh. Regarding the privacy page, I think maybe some new lines were needed (though I'm not sure why). Let's see if that helps with the issues.
@brockfanning @phillipgardiner feature branch has been refreshed
@brockfanning @LucyGwilliamAdmin Great, looks good to me :). I've only checked the new changes, not re-checked it all as assuming nothing else changed.
@brockfanning can you resolve the conflicts here when you have a chance please?
This is a replacement for #3524 (which got closed anyway), using the the GDS assets more directly.
This depends on open-sdg/open-sdg#1235 so this PR points there in remote_theme.
Some notes on the PR:
details.html
that might be useful.