search

ONSdigital / sdg-indicators

Development website for collecting and disseminating UK data for the Sustainable Development Goal global indicators.
https://ONSdigital.github.io/sdg-indicators/
37 stars 66 forks source link

Feature site map background accessible2 #3654

Closed sarah-beasley closed 1 year ago

sarah-beasley commented 1 year ago

Hi @brockfanning , I wasn't sure how to get these map background changes onto Open SDG - is that on your end? I'm assuming that we want these changes to go on Open SDG as well as the UK site? Thanks

Link to the FB - http://uk-sdg-feature-branches.s3-website.eu-west-2.amazonaws.com/feature-site-map-background-accessible2/3-3-3/

brockfanning commented 1 year ago

@sarah-beasley Since Open SDG doesn't come with any map tiles out-of-the-box, it's not something we need to get into Open SDG. That said, there is one aspect here that needs attention in Open SDG: the custom range of colors. If you were maintaining the site_config.yml file via the site configuration form, then you would not be able to have a custom range of colors. This is because on the site configuration form, that field (colorRange) only accepts a single text item.

For example, the site configuration form will allow you to do this:

colorRange: foobar

But not this:

colorRange:
  - foo
  - bar

This is not a problem for you because you are maintaining the site_config.yml file manually.

That's a long way of saying that we could open a new ticket in Open SDG like: "Support lists in site config form for map colorRange".

sarah-beasley commented 1 year ago

Thanks @brockfanning , that makes sense! I have added an issue here - #1823 for reference. Not sure whether we will need this to be actioned for 2.1.0?