search

ONSdigital / sdx-seft-consumer-service

Microservice for consuming SEFT files from RAS and sending to ONS internal
MIT License
1 stars 1 forks source link

Remove receipting from consumer service #60

Closed insacuri closed 5 years ago

insacuri commented 5 years ago

What? and Why?

https://trello.com/c/3U4nBGn2/708-708-two-receipts-to-rrm-being-sent-for-each-seft

RAS now handles the receipting when it receives the seft survey making it unnecessary to do it here. This PR removes the receipting step and goes directly to the virus scanning

Checklist

codecov[bot] commented 5 years ago

Codecov Report

Merging #60 into master will decrease coverage by 1.05%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
- Coverage   81.57%   80.51%   -1.06%     
==========================================
  Files          13       13              
  Lines         917      862      -55     
==========================================
- Hits          748      694      -54     
+ Misses        169      168       -1
Impacted Files Coverage Δ
app/settings.py 97.29% <ø> (-0.27%) :arrow_down:
app/tests/test_consumer.py 100% <ø> (ø) :arrow_up:
app/tests/test_publish_receive.py 42.42% <ø> (-0.16%) :arrow_down:
app/main.py 76.15% <100%> (-2.76%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c8b2094...b27b688. Read the comment docs.