search

ONSdigital / sdx-seft-consumer-service

Microservice for consuming SEFT files from RAS and sending to ONS internal
MIT License
1 stars 1 forks source link

Improve logging, docstrings and tidyup #76

Closed insacuri closed 5 years ago

insacuri commented 5 years ago

What? and Why?

Some of the logging around checking if the submission has finished anti virus scanning was lacking (especially around the continuous retries and what happens if it exceeds the max attempts). This PR adds more logging and metadata around this event to make diagnosing issues easier.

Also removed an unused exception class, tidied up various bits of logging in the application and added a few docstrings

Checklist

insacuri commented 5 years ago

Just added do not merge label as I need to do a quick test in preprod to make sure nothing is broken

codecov[bot] commented 5 years ago

Codecov Report

Merging #76 into master will decrease coverage by 0.04%. The diff coverage is 73.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
- Coverage   80.53%   80.48%   -0.05%     
==========================================
  Files          13       13              
  Lines         863      861       -2     
==========================================
- Hits          695      693       -2     
  Misses        168      168
Impacted Files Coverage Δ
app/main.py 75.96% <ø> (-0.37%) :arrow_down:
app/health.py 29.31% <0%> (ø) :arrow_up:
app/anti_virus_check.py 98.37% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 611b465...05a75d8. Read the comment docs.