search

ONSdigital / sdx-seft-publisher-service

Microservice for publishing SEFT files from internal to RAS
MIT License
0 stars 1 forks source link

Make routing key configurable #33

Closed JamesGardiner closed 7 years ago

JamesGardiner commented 7 years ago

The ROUTING_KEY variable was previously hardcoded to be 'JWT'. This pull request introduces a configurable version of this variable, which is instantiated using a named environment variable - SDX_SEFT_PUBLISHER_ROUTING_KEY.

In cases where this is not set, the default value will be None. In this case, the default Pika behaviour is to use the queue name as the default routing key when binding to a topic exchange. See http://pika.readthedocs.io/en/0.10.0/_modules/pika/channel.html#Channel.queue_bind for the implementation.

codecov-io commented 7 years ago

Codecov Report

Merging #33 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #33   +/-   ##
======================================
  Coverage    47.7%   47.7%           
======================================
  Files           4       4           
  Lines         327     327           
======================================
  Hits          156     156           
  Misses        171     171
Impacted Files Coverage Δ
app/publisher.py 27.64% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1a9a931...d4f47c4. Read the comment docs.