Closed insacuri closed 5 years ago
Merging #66 into master will decrease coverage by
0.16%
. The diff coverage is21.51%
.
@@ Coverage Diff @@
## master #66 +/- ##
==========================================
- Coverage 55.97% 55.81% -0.17%
==========================================
Files 8 8
Lines 611 611
==========================================
- Hits 342 341 -1
- Misses 269 270 +1
Impacted Files | Coverage Δ | |
---|---|---|
app/test/localserver.py | 33.84% <0%> (+0.51%) |
:arrow_up: |
app/publisher.py | 37.5% <17.24%> (+0.3%) |
:arrow_up: |
app/main.py | 36.6% <3.44%> (-1.15%) |
:arrow_down: |
app/ftpclient.py | 92.85% <73.33%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 719941b...c455c63. Read the comment docs.
This PR was originally to add logging around the delete functionality. It expanded into tidying up the logic, adding a lot more logging and renaming some variables to make it more intuitive.
How to test
cd <wherever your sdx-compose is>/pure-ftp-structure/EDC_Template_RAS
touch filename.xlsx