search

ONSvisual / Simple-charts

Simple responsive charts
17 stars 12 forks source link

Split bar template grumbles #62

Closed henryjameslau closed 4 years ago

henryjameslau commented 4 years ago

Somewhere in the split bar template, the domain is hardcoded

henryjameslau commented 4 years ago

Line 236

xScale.range([0, columnScale.bandwidth()]).domain([d3.min([0,dataFlatMin]), dataFlatMax]);
henryjameslau commented 4 years ago

Also xAxisScale is linked from the config to the template

henryjameslau commented 4 years ago

Also line 308 is set for dataflatmin, which is you're above zero mean you are cutting the bars

henryjameslau commented 4 years ago

Also lines 465-469, any zeros are represented by *s

henryjameslau commented 4 years ago

Fixed