OOHarryPotterOO / EEP153_Project_3_Terence_Gorman

Team Terence Gorman
0 stars 0 forks source link

Code Review: Ernst Engle #1

Open s-himalia-j opened 5 months ago

s-himalia-j commented 5 months ago

First of all, your code is absolutely beautiful. The organization is amazing and so satisfying to look at.

The code runs until Regression Result Analytics [I]. At this point, it asks me to restart my kernel and will not allow me to continue running the code. "The kernel for EEP153_Project_3_Terence_Gorman/EEP153_project_3.ipynb appears to have died. It will restart automatically." is the message I get when I try to run "result.predicted_expenditures()". Post Kernel restart, I get the error message:

"NameError Traceback (most recent call last) Cell In[1], line 2 1 ## This code may take longer than 1 minute to process. ----> 2 result.predicted_expenditures()

NameError: name 'result' is not defined"

If I attempt to reload, I get the same result.

cefayefang commented 5 months ago

Hi,

Thank you for reviewing our code. Regarding the issue you encountered with the kernel dying in the "Regression Result Analytics [I]" section. It seems like the problem might be related to the time and memory consumption. If you run the code in datahub, it provides a 4.02G memory environment and should give outcomes even though it takes some time. It works well on my end and my teammates' computers. But we will definitely look into this problem. Maybe try running it in an environment with more memory. Hopefully, this solution may work. Thanks again.