Homepage Random Selection now includes items w/out images

[bjornmeansbear]

Can we get it to go back to only items w/ images there please?

[webmasterkai]

That will have to be ported to firebase.

[webmasterkai]

There is no easy way for the browser to know if the image is missing because there is a default image set at imgix. No image error is thrown because an image is always returned from server, even if 404.

[bjornmeansbear]

Well shoot. Okay, so I'll delete the default image. And then we'll just need to figure out what to do on the pricelist?

Kristian Bjørnard 507-301-8402 @bjornmeansbear

Please pardon brevity and mistakes Sent from my phone

On Nov 21, 2016, at 11:43, Kai Curry notifications@github.com wrote:

There is no easy way for the browser to know if the image is missing because there is a default image set at imgix. No image error is thrown because an image is always returned from server, even if 404.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

[bjornmeansbear]

I deleted the missing image from imgix. So they'll for real be missing now. Um, and I guess lets hide it on the homepage, but for now they can still show up elsewhere... I'll double confirm with them what they want to happen elsewhere.

[bjornmeansbear]

This is solved?

[bjornmeansbear]

The best thing would be to get the list from b2 on the backend so we don't rely on user browsers to tell us what's missing

[webmasterkai]

Ran a script that tells firebase what items have images. The script will need to be run every time images on B2 are updated.