search

OOKB / rg-client-app

Rogers and Goffigon (most) site files.
0 stars 1 forks source link

Sometimes #detail or #collection or similar is stored in the URL even after that feature is navigated away from #223

Closed bjornmeansbear closed 10 years ago

bjornmeansbear commented 10 years ago

https://www.dropbox.com/s/cl2p3o2siz9ldn0/Screenshot%202014-10-02%2023.01.25.png?dl=0

This could be relate to #221 ?

This seems to happen most frequently on the summer sale when you've clicked to a detail and then come back.

Sometimes it instead stores a "pattern=[SOMEITEM#]" as well, which causes similar problems.

webmasterkai commented 10 years ago

correct img there?

bjornmeansbear commented 10 years ago

nope!

bjornmeansbear commented 10 years ago

dammit! now I can't for the life of me get this to happen again.

webmasterkai commented 10 years ago

to really fix this type of issue is a complete rewrite of the controller... i'll just patch at it as we find a process to reproduce but it will only fix that particular case.

webmasterkai commented 10 years ago

one thing to play with is replaceState instead of setState...

bjornmeansbear commented 10 years ago

There are a crap ton of notes from Pentagram that are probably all related to this and #221 — I haven't directly reproduced any of them yet, but yeah, they all seem similarly symptamatic...

Pricelist 19) Bug, pages don’t always load until data until I hard refresh page. For example if I hit next/prev arrows the page does not load content, and I lose all selection items other than VIEW selector. Also happens when I switch between Textiles, Passementrie and Leather.

Summersale 25) Detail view - When I close detail view things are not clickable. Potentially related to above 26) When I click Vertical View toggle, I get a “No Textiles at this time” message, hard refresh loads things in. 27) View selector creates a “No Textiles at this time” message, hard refresh fixes 28) Bug, Filter toggle sometimes becomes unclickable

Search 44) Arbitrary unclickable elements, like collection toggles. Also seems load related.

bjornmeansbear commented 10 years ago

here we go... screen shot 2014-10-02 at 11 07 36 pm

webmasterkai commented 10 years ago

Yes, but what are the steps to reproduce? :-)

bjornmeansbear commented 10 years ago

clicking a bunch of things... hmmm... I can see how that isn't helpful.

webmasterkai commented 10 years ago

A console log check would be helpful too

bjornmeansbear commented 10 years ago

Currently I get the URL thing happening on the pricelist, but it doesn't appear to have negative implications there right now. — however, clicking a detail, and then clicking close, makes the url update with the pattern number of the item you just viewed the detail of.

bjornmeansbear commented 10 years ago

Oh, but my previous comment does break the pricelist passementerie/leather views once that patter addition is added...

for example: http://localhost:3000/app.html#trade/pricelist/leather/10000/p1?pattern=803003 — if you just try to follow that URL, the site doesn't think it is valid, and sort of redirects you to the account page — but if you click a detail, then get that pattern added to the URL, then try clicking on passementerie or leather you get a no results page returned... — but! I stlll get no messages logged to console, so I don't know if this is helpful at all.

bjornmeansbear commented 10 years ago

This seems to be fixed on Pricelist related stuff... I'll double check else where.

bjornmeansbear commented 10 years ago

I think you closed this?