search

OOKB / rg-client-app

Rogers and Goffigon (most) site files.
0 stars 1 forks source link

Can clicking outside of the Filter dropdown cause it to close? #228

Closed bjornmeansbear closed 10 years ago

webmasterkai commented 10 years ago

Sure, but then what feature is going to be requested because of it? :unamused:

webmasterkai commented 10 years ago

Actually, this is going to introduce bugs. How important is it?

bjornmeansbear commented 10 years ago

well, we can leave it — I can say it either stays open when you click a filter or closes everytime you change something, we can't make it do both... this is being requested because it was how r_g.cape.io was working... and how the intended it from the beginning — it was actually something they designed and knew how they wanted it to work from the start.

Are you insinuating that it is likely to cause some other weird thing to happen? OR just that their "fix" requests never end?

bjornmeansbear commented 10 years ago

you just answered my question

I'll just say no...

webmasterkai commented 10 years ago

Personally, I like being able to click outside a box and have it close. It's just that I didn't build the filters to live in a separate component. (Story of my life) So, moving them into a new component will need to be thoroughly tested and will probably result in some unintended consequences. Since we don't have a really good testing platform setup for this project I feel like it's a little late in the game.

bjornmeansbear commented 10 years ago

We're our own worst nightmares man...

I agree with you — it's better usability wise to be able to click outside of the filter box and have that close it...

So do you want to attempt this? it sounds like a "yes, but" situation, that might just best be left alone right now.

webmasterkai commented 10 years ago

I say, let it ferment for a bit.

bjornmeansbear commented 9 years ago

This is in the "we want this, but not if it gets in the way of solving other things" category.y.