search

OOP2018 / coinpurse-WorawatCh

coinpurse-WorawatCh created by GitHub Classroom
0 stars 1 forks source link

Coins currency #14

Open chinnonae opened 6 years ago

chinnonae commented 6 years ago

Satang and Sen should not be currencies. The currency should remain Baht and Ringgit for Satang-coins and Sen-coins.

https://github.com/OOP2018/coinpurse-WorawatCh/blob/6a18a7fc8f4f028191be80da6161e134e83aa38b/src/coinpurse/MalayMoneyFactory.java#L23

https://github.com/OOP2018/coinpurse-WorawatCh/blob/6a18a7fc8f4f028191be80da6161e134e83aa38b/src/coinpurse/ThaiMoneyFactory.java#L23

chinnonae commented 6 years ago

https://github.com/OOP2018/coinpurse-WorawatCh/blob/2a14c015db518bd43001de276d6afe8734527555/src/coinpurse/MalayMoneyFactory.java#L22-L23 This is not the fix for the comment above. What I meant to say that 5-Sen coin should have the currency of Ringgit. This also apply to Thai Baht coins.

Also, your if condition is incorrect.