search

OP-DSL / OP2-Common

OP2: open-source framework for the execution of unstructured grid applications on clusters of GPUs or multi-core CPUs
https://op-dsl.github.io
Other
98 stars 47 forks source link

Fix sycl::buffer<> type casting #178

Closed aowenson closed 4 years ago

aowenson commented 4 years ago

When creating sycl::buffer objects, TYPE must be specific, no more generic char objects.

Means a change to API as type must be specified when allocating buffers, and the reallocate method has to go unless a record of the old buffer type is kept (which would need new globals in op_sycl_rt_support.h).

Also means cannot translate kernels that use consts/reductions of different types, but user will see a useful message. But did that ever work?...

aowenson commented 4 years ago

@Istvan, just giving you a chance to critique before merging.