search

OP-Engineering / op-sqlite

Fastest SQLite library for react-native by @ospfranco
MIT License
598 stars 41 forks source link

update libsql library #133

Closed haaawk closed 3 months ago

haaawk commented 3 months ago

Update libsql library to https://github.com/tursodatabase/libsql/commit/5d2501817056e186822ba29644717ef056519643

haaawk commented 3 months ago

Trying to run tests but yarn install does not seem to work any more:

╰──> yarn install
yarn install v1.22.19
error Workspaces can only be enabled in private projects.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
ospfranco commented 3 months ago

Seems unlikely, are you sure you are running yarn install in the correct folder? Nothing changed since your PR a couple of days ago.

ospfranco commented 3 months ago

OSP 000216

Checked out the PR, yarn install works on root and Example.

haaawk commented 3 months ago

I tried both in repo root and in example dir. Both fail with this error

haaawk commented 3 months ago

Ok I figured it out. It was wrong version of node.

ospfranco commented 3 months ago

Cool, I assume the tests are running, I will just go ahead and merge it. Will be released soon.

haaawk commented 3 months ago
image
haaawk commented 3 months ago
image
haaawk commented 3 months ago

Thanks @ospfranco

Volland commented 3 months ago

@ospfranco could we get a release version ?

ospfranco commented 3 months ago

already released in the latest version

ospfranco commented 3 months ago

7.3.0 is already out. You can just hover on vscode on the dependency number and it will show you the latest package version